> On June 14, 2016, 8:50 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java, > > line 1392 > > <https://reviews.apache.org/r/48576/diff/1/?file=1415445#file1415445line1392> > > > > Probably change the name to testURIsWithoutAuthority?
Neither of these tests set authority: testURIsWithAndWithoutScheme: "grant" uses URI w/ scheme, "create table" - w/o scheme; neither sets authority testURIsWithoutAndWithScheme: "grant" uses URI w/o scheme, "create table" - w/ scheme; neither sets authority So, the names only reflect what varies between "grant" and "create table", which is the scheme. If we want the name to also reflect what stays the same, i.e. missing authority, I'm fine with it, but then (a) both names should be changed for consistency, and (b) they should still reflect whether the scheme is set. It could be something like: testURIsWithAndWithoutSchemeNoAuthority testURIsWithoutAndWithSchemeNoAuthority If you think it makes sense, I'll fix it. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48576/#review137580 ----------------------------------------------------------- On June 11, 2016, 2:33 a.m., Vadim Spector wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48576/ > ----------------------------------------------------------- > > (Updated June 11, 2016, 2:33 a.m.) > > > Review request for sentry, Hao Hao and Sravya Tirukkovalur. > > > Bugs: SENTRY-1311 > https://issues.apache.org/jira/browse/SENTRY-1311 > > > Repository: sentry > > > Description > ------- > > SENTRY-1311: Improve usability of URI privileges by supporting mixed use of > URIs with and without scheme > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java > 3b9336c3e0d70b03dd6e2bf27919e2510031addd > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 1606b6d97c6696328906100eb10464fdc2fa19e8 > > Diff: https://reviews.apache.org/r/48576/diff/ > > > Testing > ------- > > > Thanks, > > Vadim Spector > >
