----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48576/#review138996 -----------------------------------------------------------
Fix it, then Ship it! Looks good to me. Left minor comments. sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java (line 124) <https://reviews.apache.org/r/48576/#comment204176> Remove? - Hao Hao On June 21, 2016, 9:52 p.m., Vadim Spector wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48576/ > ----------------------------------------------------------- > > (Updated June 21, 2016, 9:52 p.m.) > > > Review request for sentry, Hao Hao and Sravya Tirukkovalur. > > > Bugs: SENTRY-1311 > https://issues.apache.org/jira/browse/SENTRY-1311 > > > Repository: sentry > > > Description > ------- > > SENTRY-1311: Improve usability of URI privileges by supporting mixed use of > URIs with and without scheme and authority > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java > 3b9336c3e0d70b03dd6e2bf27919e2510031addd > > sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java > d7d5e0ad8635bb094b16785b6595fc9bd86df515 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 1606b6d97c6696328906100eb10464fdc2fa19e8 > > Diff: https://reviews.apache.org/r/48576/diff/ > > > Testing > ------- > > > Thanks, > > Vadim Spector > >
