----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49290/#review139706 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 1829) <https://reviews.apache.org/r/49290/#comment205030> I presume Sentry is enforcing ACLs for folder & files both. It may be worthwhile to insert some test data into table before/after rename and validate ACLs? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (lines 1835 - 1836) <https://reviews.apache.org/r/49290/#comment205031> Rename will move the directory essentially. How does 'recreating' and 'validating' useful here? Would it make sense to assert that the directory for 'tableName' doesn't exist anymore. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 1857) <https://reviews.apache.org/r/49290/#comment205034> nit: _new string :-), may be srcTable & tgtTable sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 1873) <https://reviews.apache.org/r/49290/#comment205035> missing location for external table? same for next two (partitioned table with/without partitions)? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 1877) <https://reviews.apache.org/r/49290/#comment205037> this is old location, new location is + "_new". same for next two (partitioned table with/without partitions) - Kapil Rastogi On June 28, 2016, 12:27 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49290/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 12:27 a.m.) > > > Review request for sentry, Anne Yu, Hao Hao, Kapil Rastogi, Lenni Kuff, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Adding test cases for rename table. Details are in the test class itself. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > b1d507f591323e08e0d0a0384a4525ad8b66af0c > > Diff: https://reviews.apache.org/r/49290/diff/ > > > Testing > ------- > > > Thanks, > > Sravya Tirukkovalur > >
