> On June 28, 2016, 1:28 a.m., Kapil Rastogi wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java, > > line 1829 > > <https://reviews.apache.org/r/49290/diff/2/?file=1431344#file1431344line1829> > > > > I presume Sentry is enforcing ACLs for folder & files both. It may be > > worthwhile to insert some test data into table before/after rename and > > validate ACLs?
Thats a good point. In general, we have other tests which verify the access to the files. But I agree we should add some coverage to that in these functional tests as well. Will file a follow on jira as it might be worth thinking about which all tests would be ideal candidates to get good coverage. > On June 28, 2016, 1:28 a.m., Kapil Rastogi wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java, > > line 1857 > > <https://reviews.apache.org/r/49290/diff/2/?file=1431344#file1431344line1857> > > > > nit: _new string :-), may be srcTable & tgtTable Sorry, are you recommending a new string value here or new name for the variable? I am trying to keep the same variable name, so that it is easy to know what is the current table name. If it is the string value, that does not really matter right? - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49290/#review139706 ----------------------------------------------------------- On June 28, 2016, 12:27 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49290/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 12:27 a.m.) > > > Review request for sentry, Anne Yu, Hao Hao, Kapil Rastogi, Lenni Kuff, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Adding test cases for rename table. Details are in the test class itself. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > b1d507f591323e08e0d0a0384a4525ad8b66af0c > > Diff: https://reviews.apache.org/r/49290/diff/ > > > Testing > ------- > > > Thanks, > > Sravya Tirukkovalur > >
