----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49526/#review140397 -----------------------------------------------------------
Thanks Hao Hao. Left two comments here. sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.derby.sql (line 1) <https://reviews.apache.org/r/49526/#comment205785> Need to add this file into "https://github.com/apache/sentry/blob/master/sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql"; to get it run for upgrade? The same for other 007-SENTRY-872.db.sql files. sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.derby.sql (line 12) <https://reviews.apache.org/r/49526/#comment205787> Since it's transational db, is it possible to have 3 tables? 1. AUTHZ (AUTHZ_OBJ_ID, AUTHZ_OBJ_ID, CREATE_TIME_MS) 2. MAUTHZPATHSMAPPING_PATHS(PATH_ID, PATHS); not sure if it's better for one path to have 1 row with 1 id; or a group of paths to have 1 row with 1 id, whichever maps the most privileges. 3. AUTHZ_PATHS_MAPPING(AUTHZ_OBJ_ID, PATH_ID); and corresponding foreign keys. - Anne Yu On July 1, 2016, 6:20 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49526/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 6:20 p.m.) > > > Review request for sentry and Anne Yu. > > > Repository: sentry > > > Description > ------- > > SENTRY-1365: Upgrading SQL script for HMSPaths persistence > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.postgres.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql > 927f302f789913a787b177b89af8b90a23c013ca > > Diff: https://reviews.apache.org/r/49526/diff/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
