----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49526/#review141309 -----------------------------------------------------------
Nice work Hao! Just one comment about the length of path. sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.derby.sql (line 15) <https://reviews.apache.org/r/49526/#comment206785> We use Varchar(4000) for URIs, are you sure 255 would be sufficient? - Sravya Tirukkovalur On July 5, 2016, 11:54 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49526/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 11:54 p.m.) > > > Review request for sentry and Anne Yu. > > > Repository: sentry > > > Description > ------- > > SENTRY-1365: Upgrading SQL script for HMSPaths persistence > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql > 6d08b5c0bf29a2c33f0baf5701c3efaf4b5d29d3 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql > d522026e18e6c2532487e9d4a988e408e6736008 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > d27d7b93cd3fb50d54c14c4eddee1ce59c785b13 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql > ced5c31a6a1d12dec88c39132797cf89dfa36d0f > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql > 6d563324bdf631790edce512502394b8fa81bd1f > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql > 927f302f789913a787b177b89af8b90a23c013ca > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql > fbe2dc8e285c2459c4563cda7156ce83bdf66a0a > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql > f0df187ab3299f0c87bb26eb32bee0001f45fc5a > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql > f1666be9244ada88c59107f564d7c7662299f851 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql > b39292d621ad68ff62f2585372a58c28e0eb8d37 > > Diff: https://reviews.apache.org/r/49526/diff/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
