----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49777/#review143055 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java (line 52) <https://reviews.apache.org/r/49777/#comment208751> Add unit test for HMSFollower? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java (line 112) <https://reviews.apache.org/r/49777/#comment208752> We should avoid bring down sentry service if Hive does not use Sentry. Probably do not start HMSFollower in this case? Agree we may want to retry. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java (line 145) <https://reviews.apache.org/r/49777/#comment208749> Should we check NId against currentEventID here? - Hao Hao On July 13, 2016, 12:42 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49777/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 12:42 a.m.) > > > Review request for sentry and Hao Hao. > > > Repository: sentry > > > Description > ------- > > - Adding HMSFollower and changes in Sentryservice to use it. > - Test changes - start sentryservice before hive > - Moving HiveAuthzConf to sentry-binding-hive-conf, so that > sentry-provider-db does not have to depend on sentry-binding-hive-commong > which creates a circular dependency > - Moving messaging/json to sentry-binding-hive-follower to avoid circular > dependency between sentry-hive-binding and sentry-provider-db > > > Diffs > ----- > > sentry-binding/pom.xml 30bca146786a833391fa44c62e036777b694a7b1 > sentry-binding/sentry-binding-hive-common/pom.xml > 18b422d5a688e636af4e01b382fa3e5677ac884b > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > ad19b3754527e25c6509571a47f3e31a077b9e56 > sentry-binding/sentry-binding-hive-conf/pom.xml PRE-CREATION > > sentry-binding/sentry-binding-hive-conf/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > PRE-CREATION > sentry-binding/sentry-binding-hive-follower/pom.xml PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/JSONAlterPartitionMessage.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/JSONAlterTableMessage.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAddPartitionMessage.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterPartitionMessage.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterTableMessage.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateDatabaseMessage.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropDatabaseMessage.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropPartitionMessage.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropTableMessage.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java > PRE-CREATION > sentry-provider/sentry-provider-db/pom.xml > b8143ffa3adca9e47e7cb092131d65064d57c86b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java > f54f161b381088285486a5ca74972f93ee620547 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 531ab3545e1beb79c18e713f9d97453ee258748d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > abc3f58d21bb774427a34399b6e9f51a37ba51db > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java > 767bcbe02e0d511f52bc869e7b6a1ee1e6584a5a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 2c4948e9d100f2cf0cb5b7772489194c62b8a857 > > Diff: https://reviews.apache.org/r/49777/diff/ > > > Testing > ------- > > Testing not complete yet. Submmitting a preview of changes for review as this > work also is important for SENTRY-1371 > > > Thanks, > > Sravya Tirukkovalur > >
