----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49777/ -----------------------------------------------------------
(Updated July 27, 2016, 11:58 p.m.) Review request for sentry and Hao Hao. Changes ------- Adding unit tests. Adding more negative tests in a follow on jira to unblock dependant patches. Repository: sentry Description ------- - Adding HMSFollower and changes in Sentryservice to use it. - Test changes - start sentryservice before hive - Moving HiveAuthzConf to sentry-binding-hive-conf, so that sentry-provider-db does not have to depend on sentry-binding-hive-commong which creates a circular dependency - Moving messaging/json to sentry-binding-hive-follower to avoid circular dependency between sentry-hive-binding and sentry-provider-db Diffs (updated) ----- sentry-binding/pom.xml 30bca146786a833391fa44c62e036777b694a7b1 sentry-binding/sentry-binding-hive-common/pom.xml 18b422d5a688e636af4e01b382fa3e5677ac884b sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java ad19b3754527e25c6509571a47f3e31a077b9e56 sentry-binding/sentry-binding-hive-conf/pom.xml PRE-CREATION sentry-binding/sentry-binding-hive-conf/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java PRE-CREATION sentry-binding/sentry-binding-hive-follower/pom.xml PRE-CREATION sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/JSONAlterPartitionMessage.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/JSONAlterTableMessage.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAddPartitionMessage.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterPartitionMessage.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterTableMessage.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateDatabaseMessage.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropDatabaseMessage.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropPartitionMessage.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropTableMessage.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryInvalidHMSEventException.java PRE-CREATION sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryInvalidInputException.java 903eddc60e12ae80c005bf8153ba5356532ac1b6 sentry-provider/sentry-provider-db/pom.xml b8143ffa3adca9e47e7cb092131d65064d57c86b sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java f54f161b381088285486a5ca74972f93ee620547 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 51dde0e5fcfb9dd93a47351efa3a78692bb60202 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java abc3f58d21bb774427a34399b6e9f51a37ba51db sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 439b9de1fc85957bb3b26de145dbf9bd365c5347 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java 847da45dcc884d7d573b10a18d3122292754c8ad Diff: https://reviews.apache.org/r/49777/diff/ Testing ------- Testing not complete yet. Submmitting a preview of changes for review as this work also is important for SENTRY-1371 Thanks, Sravya Tirukkovalur
