----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/#review144007 -----------------------------------------------------------
Thanks for picking this up Hao! Appreciate it! Do we need to update the non pool java clients as well? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java (line 142) <https://reviews.apache.org/r/50578/#comment209944> Supportability: Shall we Log.info these end points during start up? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java (line 147) <https://reviews.apache.org/r/50578/#comment209946> Nit: Can we add a comment on what are the valid hostsAndPortStrings here? Or just refer to the test case? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java (lines 244 - 254) <https://reviews.apache.org/r/50578/#comment209950> Handling both exceptions similarly? If so, catch (SentryStandbyException|TTransportException e) { sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java (lines 256 - 264) <https://reviews.apache.org/r/50578/#comment209953> Seems like endPointIdx will always be the same as curFreshestEndpointIdx? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java (lines 269 - 274) <https://reviews.apache.org/r/50578/#comment209955> It is not very clear what we are trying to achieve here. Seems like the order of endpoints matter as per this logic? sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceWithInvalidMsgSize.java (line 107) <https://reviews.apache.org/r/50578/#comment209958> Is this change in behavior required? sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestPoolClientInvocationHandler.java (line 26) <https://reviews.apache.org/r/50578/#comment209960> I only see tests for hostString parsing logic, shall we add tests for actual standbyException handling? - Sravya Tirukkovalur On July 28, 2016, 9:14 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50578/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 9:14 p.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > The sentry client should retry configurable times RPCs if it gets a > SentryStandbyException > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryStandbyException.java > b2df699b962def9ef2dbf60fe8f601f9aaeb03f5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > 1039e6ebfde32ec8db82287458b8b4b6a23136a3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java > a35bf1d4781c7424283610c7fa67ede990e35fef > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java > 56d774b883914dbffff438101f47fb94518c94d5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientPoolFactory.java > afea78a0bea754f950cc7e3033e1b1ebfdcb35fc > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceWithInvalidMsgSize.java > 15eab15b79f9057d173e0ea4ea64e152ade698d6 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestPoolClientInvocationHandler.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50578/diff/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
