----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/#review149898 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java (line 278) <https://reviews.apache.org/r/50578/#comment217665> endpointIdx -> i ? also in line282 Also consider the situation when exec[i] == null - Li Li On Aug. 2, 2016, 9:55 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50578/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 9:55 p.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > The sentry client should retry configurable times RPCs if it gets a > SentryStandbyException > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryStandbyException.java > b2df699b962def9ef2dbf60fe8f601f9aaeb03f5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > 1039e6ebfde32ec8db82287458b8b4b6a23136a3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java > a35bf1d4781c7424283610c7fa67ede990e35fef > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java > 56d774b883914dbffff438101f47fb94518c94d5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientPoolFactory.java > afea78a0bea754f950cc7e3033e1b1ebfdcb35fc > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceFailureCase.java > 51bba31bddc4404506bbe42f9f8d444b36d5056c > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceWithInvalidMsgSize.java > 15eab15b79f9057d173e0ea4ea64e152ade698d6 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestPoolClientInvocationHandler.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50578/diff/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
