> On Oct. 13, 2016, 11:19 p.m., Sravya Tirukkovalur wrote: > > Thanks for the patch Hao! I suspect new Listener tests would fail with this > > patch, unless those tests are enabling useNotificationLog? > > > > Also, would it be possible to just add back the old listener with a > > different name? So that it is easy to review as Notification listener would > > not change? > > > > And there will be other parts of the code eventually which would also need > > to be switched with this flag? For example: The way deltas are served. Do > > we plan to maintain backward compatibility all through?
Thanks Sravya for review. For the name I think it is better to be more specific in the class name? For the question: "And there will be other parts of the code eventually which would also need to be switched with this flag?" Yes, we will need it. - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52795/#review152586 ----------------------------------------------------------- On Oct. 12, 2016, 6:12 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52795/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 6:12 p.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Li Li, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > SENTRY-1499: Add feature flag for using NotificationLog > > 1. Keep two SentryMetastorePostEventListeners. One for using notificationlog, > another for not. > 2. Add feature flag for using HMSFollower and > SentryMetastorePostEventListeners with notification log. > > Change-Id: I46a11d27ae0159a735b6049e9b7c78216d0e5346 > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > 75190c1805162e11baf7c4553668693e4e6bb3c4 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerNotificationLog.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 9e9358b8bdcfb4177d0320da26739d990d287f09 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > f98ebd135a383ff090b1b204cc62644403310df7 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 61b24fa0e9f221b75ae343fc534b4d82fbce272a > > Diff: https://reviews.apache.org/r/52795/diff/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
