> On Dec. 17, 2016, 1:48 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java, > > line 108 > > <https://reviews.apache.org/r/52795/diff/3/?file=1588262#file1588262line108> > > > > Consider using static import for CLASS_SPLITTER
What is the reason to use static import here since CLASS_SPLITTER is only used once? > On Dec. 17, 2016, 1:48 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java, > > line 136 > > <https://reviews.apache.org/r/52795/diff/3/?file=1588262#file1588262line136> > > > > This code is repeated everywhere - is it possible to handle it in a > > generic way? Yeah, I agree. But I would rather to touch the core code in a follow up jira as the main purpose of this one is to add feature flag. I just simply copied back the original SentryMetastorePostEventListener class here. > On Dec. 17, 2016, 1:48 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java, > > line 151 > > <https://reviews.apache.org/r/52795/diff/3/?file=1588262#file1588262line151> > > > > What is ment by drop here? The method is about creating a table. AFAIU, the drop here was used to make sure no privilege existed before creating this table. - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52795/#review159534 ----------------------------------------------------------- On Dec. 16, 2016, 10:03 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52795/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2016, 10:03 p.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, kalyan kumar > kalvagadda, Li Li, and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > SENTRY-1499: Add feature flag for using NotificationLog > > 1. Keep two SentryMetastorePostEventListeners. One for using notificationlog, > another for not. > 2. Add feature flag for using HMSFollower and > SentryMetastorePostEventListeners with notification log. > > Change-Id: I46a11d27ae0159a735b6049e9b7c78216d0e5346 > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > 75190c1805162e11baf7c4553668693e4e6bb3c4 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerNotificationLog.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > a9d49f86961f1ced1af40afcfe6172f884a23d44 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > d80fa1e71c165b7f1faf1c50c451e049d76b770b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 61b24fa0e9f221b75ae343fc534b4d82fbce272a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerInBuiltDeserializer.java > c4be62db71e67099f22f3ba8991e03a32fb0f28a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java > 6f1886f942ca80ab4c356b81777d3ac336017292 > > Diff: https://reviews.apache.org/r/52795/diff/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
