----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/#review166234 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 428) <https://reviews.apache.org/r/56720/#comment238138> I mean the two statements doing the purge should stay unless you thing there is a reason not to. - Alexander Kolbasov On Feb. 21, 2017, 9:47 p.m., Lei Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56720/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 9:47 p.m.) > > > Review request for sentry, Alexander Kolbasov and Hao Hao. > > > Bugs: SENTRY-1611 > https://issues.apache.org/jira/browse/SENTRY-1611 > > > Repository: sentry > > > Description > ------- > > Provide a background service to periodically purge path and permission delta > change tables. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java > 952b11f4e81426ec51c0ad6131ad579ba5e3383e > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java > 3662bfdebd1a4e2172ab83bd8c8e60ccf21b55b9 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 4cc123fd0de05a055b4276d213eafc0eb070213d > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > dfaac1555fe729efab3f8fdccb914978001fee56 > > Diff: https://reviews.apache.org/r/56720/diff/ > > > Testing > ------- > > Run `mvn test -Dtest=TestSentryStore` > > > Thanks, > > Lei Xu > >
