> On Feb. 21, 2017, 2:40 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 492 > > <https://reviews.apache.org/r/56720/diff/5/?file=1641587#file1641587line492> > > > > Can you please also log the changeID of the one been kept.
It might not be possible in such implementation, as the SQL was sent in one trip. The changeID is not returned during the middle of the transaction. > On Feb. 21, 2017, 2:40 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 479 > > <https://reviews.apache.org/r/56720/diff/5/?file=1641587#file1641587line479> > > > > Not quite follow why deletePersistentAll with changesToKeep here? As per asked by Sasha, we provide the capability to specifiy the number of records to keep for testing purpose. So here, `changesToKeep` is a parameter passed to the query's filter. - Lei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56720/#review166238 ----------------------------------------------------------- On Feb. 21, 2017, 1:47 p.m., Lei Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56720/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 1:47 p.m.) > > > Review request for sentry, Alexander Kolbasov and Hao Hao. > > > Bugs: SENTRY-1611 > https://issues.apache.org/jira/browse/SENTRY-1611 > > > Repository: sentry > > > Description > ------- > > Provide a background service to periodically purge path and permission delta > change tables. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java > 952b11f4e81426ec51c0ad6131ad579ba5e3383e > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java > 3662bfdebd1a4e2172ab83bd8c8e60ccf21b55b9 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 4cc123fd0de05a055b4276d213eafc0eb070213d > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > dfaac1555fe729efab3f8fdccb914978001fee56 > > Diff: https://reviews.apache.org/r/56720/diff/ > > > Testing > ------- > > Run `mvn test -Dtest=TestSentryStore` > > > Thanks, > > Lei Xu > >
