----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57220/#review167584 -----------------------------------------------------------
Fix it, then Ship it! Ship It! sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo Lines 269 (patched) <https://reviews.apache.org/r/57220/#comment239488> Do we need to index by this column or enforce uniqueness? - Alexander Kolbasov On March 1, 2017, 9:49 p.m., Lei Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57220/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 9:49 p.m.) > > > Review request for sentry and Hao Hao. > > > Bugs: SENTRY-1638 > https://issues.apache.org/jira/browse/SENTRY-1638 > > > Repository: sentry > > > Description > ------- > > This work is similar to SENTRY-1448, that adds a notification ID field in > MSentryPermChange to be persistanted > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java > 476fbcb2ad26de23757842111beb12b154e1562b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > e981bcf0f327346c09cdbe5785fb8824fc62e704 > > > Diff: https://reviews.apache.org/r/57220/diff/1/ > > > Testing > ------- > > mvn clean package > > > Thanks, > > Lei Xu > >
