> On March 2, 2017, 9:40 a.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Lines 287 (patched) > > <https://reviews.apache.org/r/57220/diff/2/?file=1652981#file1652981line287> > > > > SENTRY-1638, need changes to sql script scripts for 5 different > > databases. What is the plan for that? > > Lei Xu wrote: > I mis-understood the intention of this JIRA. This JIRA should be changing > the 5 sql scripts for `MSentryPathChange`. I will do that in a new patch. > > kalyan kumar kalvagadda wrote: > I will add required sql changes needed for notification id. I have jira > SENTRY-1569 which handles the sql changes for SENTRY_PERM_CHANGE and > SENTRY_PATH_CHANGE tables.
That'd be great. Thanks Kalyan! I will close this JIRA then. Btw, Hao mentioned that only MSentryPathChange should have notification ID. - Lei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57220/#review167691 ----------------------------------------------------------- On March 1, 2017, 2:23 p.m., Lei Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57220/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 2:23 p.m.) > > > Review request for sentry and Hao Hao. > > > Bugs: SENTRY-1638 > https://issues.apache.org/jira/browse/SENTRY-1638 > > > Repository: sentry > > > Description > ------- > > This work is similar to SENTRY-1448, that adds a notification ID field in > MSentryPermChange to be persistanted > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java > 476fbcb2ad26de23757842111beb12b154e1562b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > e981bcf0f327346c09cdbe5785fb8824fc62e704 > > > Diff: https://reviews.apache.org/r/57220/diff/2/ > > > Testing > ------- > > mvn clean package > > > Thanks, > > Lei Xu > >
