> On May 8, 2017, 7:48 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/SentryHdfsServiceIntegrationBase.java > > Line 62 (original), 59 (patched) > > <https://reviews.apache.org/r/58727/diff/1/?file=1700180#file1700180line62> > > > > When we run multiple servers, they will have multiple addresses (IP and > > port). How do you configure all of them, not just the first one?
All the sentry servers share the same IP but have different port. When the server comes-up for the first time, a free port is taken and then stored. When that instance of server is restarted same is re used again. > On May 8, 2017, 7:48 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceFailureCase.java > > Line 25 (original), 25 (patched) > > <https://reviews.apache.org/r/58727/diff/1/?file=1700182#file1700182line25> > > > > remove the line if you don't need it Fixed in the later patches. > On May 8, 2017, 7:48 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java > > Line 59 (original), 59 (patched) > > <https://reviews.apache.org/r/58727/diff/1/?file=1700183#file1700183line59> > > > > You only check the first server here. should you test the other servers? Scope of this Jira to extend all the base classes to have capabilty to deal with multiple serves. None of the tests are changes. They still behave the same way. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58727/#review173643 ----------------------------------------------------------- On May 12, 2017, 3:49 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58727/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 3:49 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1708 > https://issues.apache.org/jira/browse/SENTRY-1708 > > > Repository: sentry > > > Description > ------- > > Here is the abstract of the code changes done. There are basically changes to > the base classes used tests to be able to handle multiple servers > List of sentry sentry servers > List of the address used for these servers > This is learnt so re-use the same port when the servers are re-started > API's to start/stop all the servers > API's to start/stop specific servers > API to lean the server addresses > API to update the sentry server config list for the clients to use > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/SentryHdfsServiceIntegrationBase.java > eccf83b > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceClient.java > 8959ad8 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyServiceClient.java > 3b3b30e > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceClientPool.java > fe4164d > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceFailureCase.java > 7c7ebab > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java > a33b03a > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceWithInvalidMsgSize.java > a4dd8a6 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > dd37e7e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > 17a2d1e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithHAGrantOption.java > 53cbd00 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > e2fb36a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > 054b193 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java > dac1151 > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java > bead003 > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/AbstractSqoopSentryTestBase.java > 8a01e1c > > > Diff: https://reviews.apache.org/r/58727/diff/3/ > > > Testing > ------- > > Made sure that all the db-provider unit tests passed. > > > Thanks, > > kalyan kumar kalvagadda > >
