----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58727/ -----------------------------------------------------------
(Updated July 12, 2017, 4:44 p.m.) Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. Changes ------- There is one test failure doesn;t seem to be related to changes done.I'm looking into it. Bugs: SENTRY-1708 https://issues.apache.org/jira/browse/SENTRY-1708 Repository: sentry Description (updated) ------- Here is the abstract of the code changes done. There are basically changes to the base classes used tests to be able to handle multiple servers * List of sentry sentry servers * List of the address used for these servers * This is learnt so re-use the same port when the servers are re-started * API's to start/stop all the servers * API's to start/stop specific servers * API to learn the server addresses * API to update the sentry server config list for the clients to use * API to for service failover There are some HA test classes added to demonstrate the how these abstract base classes can be used to perform HA tests. Model HA Tests using Abstract class providing Ha capability * TestColumnEndToEndWithHa * TestGrantUserToRoleWithHa * TestPrivilegeWithHAGrantOption Diffs (updated) ----- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java fd07887 sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/SentryHdfsServiceIntegrationBase.java 3ee3724 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceClient.java 8959ad8 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyServiceClient.java 3b3b30e sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyServiceClientWithHa.java PRE-CREATION sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceClientPool.java fe4164d sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceFailureCase.java 2f4e8f6 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java a33b03a sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceWithInvalidMsgSize.java 32e67b9 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java 6895720 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java b416ef8 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java aa99595 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestGrantUserToRole.java 5364937 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithHAGrantOption.java f3db301 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestColumnEndToEndWithHa.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestGrantUserToRoleWithHa.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 6ea6763 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 4cfb1f7 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java 9139706 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrvFactory.java 9381e88 sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java 7c45999 sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAclsCrud.java a52c8d6 sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/AbstractSqoopSentryTestBase.java 80f158a Diff: https://reviews.apache.org/r/58727/diff/4/ Changes: https://reviews.apache.org/r/58727/diff/3-4/ Testing (updated) ------- Made sure that all the unit tests passed. Thanks, kalyan kumar kalvagadda