----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60499/#review179155 -----------------------------------------------------------
bin/sentryShell Line 60 (original), 60 (patched) <https://reviews.apache.org/r/60499/#comment253700> Why not use getopt instead? bin/sentryShell Line 61 (original), 61 (patched) <https://reviews.apache.org/r/60499/#comment253699> Even better, we should just ignore the case, require lower case in command and use case statement. - Alexander Kolbasov On June 28, 2017, 11:15 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60499/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 11:15 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1823 > https://issues.apache.org/jira/browse/SENTRY-1823 > > > Repository: sentry > > > Description > ------- > > The sentryShell currently only works with Hive. This task is to get it to > work with other types (Kafka/Solr). > > > Diffs > ----- > > bin/sentryShell d21a65f7 > > > Diff: https://reviews.apache.org/r/60499/diff/1/ > > > Testing > ------- > > Tested that it gets the correct privileges for Hive + Kafka. > > > Thanks, > > Colm O hEigeartaigh > >
