> On June 28, 2017, 7:20 p.m., Alexander Kolbasov wrote:
> > bin/sentryShell
> > Line 60 (original), 60 (patched)
> > <https://reviews.apache.org/r/60499/diff/1/?file=1766139#file1766139line60>
> >
> >     Why not use getopt instead?

getopt does not support long options (--type) on OSX.


- Colm


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60499/#review179155
-----------------------------------------------------------


On June 29, 2017, 10:50 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60499/
> -----------------------------------------------------------
> 
> (Updated June 29, 2017, 10:50 a.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-1823
>     https://issues.apache.org/jira/browse/SENTRY-1823
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> The sentryShell currently only works with Hive. This task is to get it to 
> work with other types (Kafka/Solr).
> 
> 
> Diffs
> -----
> 
>   bin/sentryShell d21a65f7 
> 
> 
> Diff: https://reviews.apache.org/r/60499/diff/2/
> 
> 
> Testing
> -------
> 
> Tested that it gets the correct privileges for Hive + Kafka.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Reply via email to