----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60502/#review179318 -----------------------------------------------------------
I see a lot of remains from old sentry HA still - the purpose of this JIRA is ot get rid of them. sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java Line 82 (original), 82 (patched) <https://reviews.apache.org/r/60502/#comment253965> Should this be removed as well? sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java Line 153 (original), 153 (patched) <https://reviews.apache.org/r/60502/#comment253966> Is this still needed? sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java Line 91 (original), 91 (patched) <https://reviews.apache.org/r/60502/#comment253967> Is this still needed? sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java Line 116 (original), 116 (patched) <https://reviews.apache.org/r/60502/#comment253968> This should go away as well sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java Line 90 (original), 90 (patched) <https://reviews.apache.org/r/60502/#comment253969> This should go away sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java Line 525 (original), 525 (patched) <https://reviews.apache.org/r/60502/#comment253970> This should go away sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java Line 116 (original), 116 (patched) <https://reviews.apache.org/r/60502/#comment253971> This should go away - Alexander Kolbasov On June 28, 2017, 3:19 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60502/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 3:19 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, > Sergio Pena, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Remove the definition and usage of SENTRY_HA_ENABLED > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > d3c96fa > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > dd37e7e > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > d843829 > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > 054b193 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > 17a2d1e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > fe68f49 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > 054b193 > > > Diff: https://reviews.apache.org/r/60502/diff/1/ > > > Testing > ------- > > unit tests > > > Thanks, > > Na Li > >
