> On June 30, 2017, 1:21 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > > Line 153 (original), 153 (patched) > > <https://reviews.apache.org/r/60502/diff/1/?file=1766264#file1766264line153> > > > > Is this still needed?
removed > On June 30, 2017, 1:21 a.m., Alexander Kolbasov wrote: > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > > Line 91 (original), 91 (patched) > > <https://reviews.apache.org/r/60502/diff/1/?file=1766265#file1766265line91> > > > > Is this still needed? removed > On June 30, 2017, 1:21 a.m., Alexander Kolbasov wrote: > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > > Line 116 (original), 116 (patched) > > <https://reviews.apache.org/r/60502/diff/1/?file=1766266#file1766266line116> > > > > This should go away as well removed > On June 30, 2017, 1:21 a.m., Alexander Kolbasov wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > > Line 90 (original), 90 (patched) > > <https://reviews.apache.org/r/60502/diff/1/?file=1766267#file1766267line90> > > > > This should go away removed > On June 30, 2017, 1:21 a.m., Alexander Kolbasov wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > > Line 525 (original), 525 (patched) > > <https://reviews.apache.org/r/60502/diff/1/?file=1766268#file1766268line525> > > > > This should go away removed > On June 30, 2017, 1:21 a.m., Alexander Kolbasov wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > > Line 116 (original), 116 (patched) > > <https://reviews.apache.org/r/60502/diff/1/?file=1766269#file1766269line116> > > > > This should go away removed - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60502/#review179318 ----------------------------------------------------------- On June 30, 2017, 8:37 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60502/ > ----------------------------------------------------------- > > (Updated June 30, 2017, 8:37 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, > Sergio Pena, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Remove the definition and usage of SENTRY_HA_ENABLED > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 83f00ca > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerForPoolWithoutKerberos.java > 62fbb2f > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceForPoolWithKerberos.java > bd3c1cc > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > dd37e7e > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > d843829 > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithHAGrantOption.java > 70b48e1 > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/ha/TestHaEnd2End.java > 07d74b5 > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 458e91d > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > 054b193 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > 17a2d1e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithHAGrantOption.java > 53cbd00 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java > 1c7cd8b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > fe68f49 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > 054b193 > > > Diff: https://reviews.apache.org/r/60502/diff/2/ > > > Testing > ------- > > unit tests > > > Thanks, > > Na Li > >
