----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60904/#review180753 -----------------------------------------------------------
pom.xml Lines 76 (patched) <https://reviews.apache.org/r/60904/#comment255966> Should this comment be removed? pom.xml Lines 808 (patched) <https://reviews.apache.org/r/60904/#comment255967> Can we have a <hive-v1.version> and <hive-v2.version> in the list of versions just to keep a consistent list? We could use these newer variables just to override the <hive.version> in a profile. sentry-provider/sentry-provider-db/pom.xml Lines 146 (patched) <https://reviews.apache.org/r/60904/#comment255968> What is this RELEASE version? - Sergio Pena On July 17, 2017, 4:41 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60904/ > ----------------------------------------------------------- > > (Updated July 17, 2017, 4:41 p.m.) > > > Review request for sentry, Colm O hEigeartaigh and Sergio Pena. > > > Bugs: ENTRY-1849 > https://issues.apache.org/jira/browse/ENTRY-1849 > > > Repository: sentry > > > Description > ------- > > Currently when hive-authz2 profile is used hive version 1.1.0 dependencies > are applied in > sentry-binding-hive-follower > sentry-binding-hive > sentry-hdfs-service > packages. > Instead hive-2 dependencies should be applied. > Solution Approach: When hive-authz2 profile is used all the hive dependencies > should use appropriate version of hive. > Attach one or more files to this issue > > > Diffs > ----- > > pom.xml 2c109a4 > sentry-binding/sentry-binding-hive-common/pom.xml 0cdb739 > sentry-binding/sentry-binding-hive-conf/pom.xml 8539f5b > sentry-binding/sentry-binding-hive-follower/pom.xml f9f57ad > sentry-binding/sentry-binding-hive-v2/pom.xml eafc0ad > sentry-binding/sentry-binding-hive/pom.xml f7a889a > sentry-hdfs/sentry-hdfs-common/pom.xml 96f5f81 > sentry-hdfs/sentry-hdfs-dist/pom.xml 4674fc0 > sentry-provider/sentry-provider-db/pom.xml 12f50f9 > sentry-tests/sentry-tests-hive-v2/pom.xml d648ba4 > sentry-tests/sentry-tests-hive/pom.xml da75abd > > > Diff: https://reviews.apache.org/r/60904/diff/1/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >