> On July 17, 2017, 8:11 p.m., Colm O hEigeartaigh wrote: > > > <version>RELEASE</version> > > > > Is this a mistake? > > kalyan kumar kalvagadda wrote: > no it is not. Currently when hive-authz1 profiles is used sentry depends > on Hive 1.1.0 for all the hive dependencies except for > hive-hcatalog-server-extensions. It uses release version to get the > notification log implementation neeeded for sentry HA. This is not correct. > In this patch i retained that behaviour as it break current code if I change > it. I'm sending a mail to sentry community explaining it in detail. > > kalyan kumar kalvagadda wrote: > I'm veryfying that. If that is not the case i will change the RELEASE to > appropriate version of hive which is picked from the profile used.
I have removed RELEASE and changed it appropriately. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60904/#review180729 ----------------------------------------------------------- On July 18, 2017, 11:12 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60904/ > ----------------------------------------------------------- > > (Updated July 18, 2017, 11:12 p.m.) > > > Review request for sentry, Colm O hEigeartaigh and Sergio Pena. > > > Bugs: ENTRY-1849 > https://issues.apache.org/jira/browse/ENTRY-1849 > > > Repository: sentry > > > Description > ------- > > Currently when hive-authz2 profile is used hive version 1.1.0 dependencies > are applied in > sentry-binding-hive-follower > sentry-binding-hive > sentry-hdfs-service > packages. > Instead hive-2 dependencies should be applied. > Solution Approach: When hive-authz2 profile is used all the hive dependencies > should use appropriate version of hive. > Attach one or more files to this issue > > > Diffs > ----- > > pom.xml 2c109a4 > sentry-binding/sentry-binding-hive-common/pom.xml f48c625 > sentry-binding/sentry-binding-hive-conf/pom.xml 8539f5b > sentry-binding/sentry-binding-hive-follower/pom.xml f9f57ad > sentry-binding/sentry-binding-hive-v2/pom.xml eafc0ad > sentry-binding/sentry-binding-hive/pom.xml 02c8ac1 > sentry-hdfs/sentry-hdfs-common/pom.xml 96f5f81 > sentry-hdfs/sentry-hdfs-dist/pom.xml 4674fc0 > sentry-provider/sentry-provider-db/pom.xml 12f50f9 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java > 3a5ba46 > sentry-tests/sentry-tests-hive-v2/pom.xml d648ba4 > sentry-tests/sentry-tests-hive/pom.xml da75abd > > > Diff: https://reviews.apache.org/r/60904/diff/2/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
