-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60869/#review180853
-----------------------------------------------------------




sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java
Line 91 (original), 95 (patched)
<https://reviews.apache.org/r/60869/#comment256152>

    In sentry-site.xml.hive-client.template, I see the "sentry.provider"
    
    <property>
        <name>sentry.provider</name>
        
<value>org.apache.sentry.provider.file.HadoopGroupResourceAuthorizationProvider</value>
        <description> Deprecated name: hive.sentry.provider.  Group mapping 
which should be used at client side</description>
      </property>
      
    Can you change that file to be consistent?


- Na Li


On July 14, 2017, 3:47 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60869/
> -----------------------------------------------------------
> 
> (Updated July 14, 2017, 3:47 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-1846
>     https://issues.apache.org/jira/browse/SENTRY-1846
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Right now, we use an inconsistent set of properties to define the sentry 
> provider:
> 
> a) Hive: sentry.provider
> b) Kafka: sentry.kafka.provider
> c) Sqoop: sentry.sqoop.provider
> d) Solr: sentry.provider
> 
> This task is to make things consistent by switching hive to use 
> "sentry.hive.provider" and solr to "sentry.solr.provider". The old properties 
> will still be supported as "deprecated" properties.
> 
> 
> Diffs
> -----
> 
>   
> sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java
>  ad19b375 
>   
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java
>  c63cf642 
>   
> sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/conf/SolrAuthzConf.java
>  b31f4faf 
> 
> 
> Diff: https://reviews.apache.org/r/60869/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Reply via email to