----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60869/#review180857 -----------------------------------------------------------
Ship it! with Na Li's change ship it - Brian Towles On July 14, 2017, 10:47 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60869/ > ----------------------------------------------------------- > > (Updated July 14, 2017, 10:47 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1846 > https://issues.apache.org/jira/browse/SENTRY-1846 > > > Repository: sentry > > > Description > ------- > > Right now, we use an inconsistent set of properties to define the sentry > provider: > > a) Hive: sentry.provider > b) Kafka: sentry.kafka.provider > c) Sqoop: sentry.sqoop.provider > d) Solr: sentry.provider > > This task is to make things consistent by switching hive to use > "sentry.hive.provider" and solr to "sentry.solr.provider". The old properties > will still be supported as "deprecated" properties. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > ad19b375 > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java > c63cf642 > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/conf/SolrAuthzConf.java > b31f4faf > > > Diff: https://reviews.apache.org/r/60869/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
