----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61264/ -----------------------------------------------------------
Review request for sentry and Colm O hEigeartaigh. Bugs: SENTRY-1843 https://issues.apache.org/jira/browse/SENTRY-1843 Repository: sentry Description ------- Message definition for the MessageFactory defined in org.apache.hive.hcatalog package is changes in Hive 2.x. We need to have a different for sentry-binding-hive-follower for hive 2.x. we need to maintain support for both for Hive 1.1.0 and Hive 2.x until all the test failures with 2.x are properly handled. when we know support for 2.x is stable, we can change the default dependency on hive to Hive 2.x and eventually remove support for hive 1.1.0. When this happens we will not have duplicate code. Diffs ----- sentry-binding/pom.xml 71fe47c sentry-binding/sentry-binding-hive-follower-v2/pom.xml PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAddPartitionMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterPartitionMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterTableMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateDatabaseMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropDatabaseMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropPartitionMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropTableMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java PRE-CREATION sentry-provider/sentry-provider-db/pom.xml 7b13cea Diff: https://reviews.apache.org/r/61264/diff/1/ Testing ------- Thanks, kalyan kumar kalvagadda