----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61264/ -----------------------------------------------------------
(Updated Aug. 2, 2017, 11:51 a.m.) Review request for sentry and Colm O hEigeartaigh. Changes ------- Fixed the indentation in all the files in sentry-binding-hive-follower and sentry-binding-hive-follower-v2 Bugs: SENTRY-1843 https://issues.apache.org/jira/browse/SENTRY-1843 Repository: sentry Description ------- Message definition for the MessageFactory defined in org.apache.hive.hcatalog package is changes in Hive 2.x. We need to have a different for sentry-binding-hive-follower for hive 2.x. we need to maintain support for both for Hive 1.1.0 and Hive 2.x until all the test failures with 2.x are properly handled. when we know support for 2.x is stable, we can change the default dependency on hive to Hive 2.x and eventually remove support for hive 1.1.0. When this happens we will not have duplicate code. Diffs (updated) ----- sentry-binding/pom.xml 71fe47c sentry-binding/sentry-binding-hive-follower-v2/pom.xml PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAddPartitionMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterPartitionMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterTableMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateDatabaseMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropDatabaseMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropPartitionMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropTableMessage.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java PRE-CREATION sentry-binding/sentry-binding-hive-follower-v2/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java PRE-CREATION sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAddPartitionMessage.java 5c656eb sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterPartitionMessage.java 161bf4d sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterTableMessage.java b590fe8 sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateDatabaseMessage.java 1118cac sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java 8716316 sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropDatabaseMessage.java f38f69b sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropPartitionMessage.java e2c1135 sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropTableMessage.java 40bf2b9 sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java 5f2287e sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java b949ee5 sentry-provider/sentry-provider-db/pom.xml 7b13cea Diff: https://reviews.apache.org/r/61264/diff/2/ Changes: https://reviews.apache.org/r/61264/diff/1-2/ Testing ------- Thanks, kalyan kumar kalvagadda