----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62221/#review185101 -----------------------------------------------------------
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java Lines 169-177 (original), 170-178 (patched) <https://reviews.apache.org/r/62221/#comment261328> This is a good improvement to have but i meant DBUpdateForwarder where it doens't have anything to differentiate between PATH and PERM. We can do something like retriever.getClass().getName() to identify the type of operation being performed. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 326 (original), 328 (patched) <https://reviews.apache.org/r/62221/#comment261329> We want a message like this printed when it is the first time HMSFollower ran through the entire operation after the clean restart of server. - Vamsee Yarlagadda On Sept. 11, 2017, 6:56 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62221/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2017, 6:56 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Na Li, Sergio > Pena, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Sentry Supportability improvement. > > 1. HMSFollower > * Print confirmation message (at INFO level) once full snapshot is persisted > in the DB. > * Print the message that HMSFollower is completely ready (after the initial > pass of HMSFollower is done) > > 2. DBUpdateForwarder > * Every log message should explicitly mention which type of events is it > referring to (PERM or PATH) otherwise there is no way for us to differentiate > between calls. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > 1318082d3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > b600487dc > > > Diff: https://reviews.apache.org/r/62221/diff/2/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
