> On Sept. 11, 2017, 7:03 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 326 (original), 328 (patched) > > <https://reviews.apache.org/r/62221/diff/2/?file=1819594#file1819594line328> > > > > We want a message like this printed when it is the first time > > HMSFollower ran through the entire operation after the clean restart of > > server. > > Arjun Mishra wrote: > I added "LOGGER.debug("HMSFollower is connected to HMS. Looking for new > notifications to process");" log. Is that not sufficient? Will it be enough > if I changed it to INFO level? > > Arjun Mishra wrote: > There is also a "LOGGER.info("Starting HMSFollower to HMS {}", > metastoreURI);" statement in SentryService right when sentry service is > started
Yes we would have to make it INFO level but at the same time, with the current logic as is this will be printed everytime HMSFollower is invoked (which is every half a second) which is a lot. So we should have this printed only once at the time HMSFollower was first run. - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62221/#review185101 ----------------------------------------------------------- On Sept. 11, 2017, 6:56 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62221/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2017, 6:56 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Na Li, Sergio > Pena, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Sentry Supportability improvement. > > 1. HMSFollower > * Print confirmation message (at INFO level) once full snapshot is persisted > in the DB. > * Print the message that HMSFollower is completely ready (after the initial > pass of HMSFollower is done) > > 2. DBUpdateForwarder > * Every log message should explicitly mention which type of events is it > referring to (PERM or PATH) otherwise there is no way for us to differentiate > between calls. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > 1318082d3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > b600487dc > > > Diff: https://reviews.apache.org/r/62221/diff/2/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
