-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65704/#review198129
-----------------------------------------------------------




sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java
Lines 146 (patched)
<https://reviews.apache.org/r/65704/#comment278238>

    Lina/Sergio,
    I have a comment here. In your discussion you are saying 
    "it is impossible for one the these {old db name, new db name, old table 
name, new table name} to be null". 
    
    It means we don't expect it to happen and I think it should be logged with 
WARN debug level. This is logged in HMS and log we get while handling the 
notification would be in Sentry.


- kalyan kumar kalvagadda


On Feb. 22, 2018, 1:28 a.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65704/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2018, 1:28 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and 
> Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> wait for HMS sync at alter table, which including table rename and changing 
> table columns
> 
> 
> Diffs
> -----
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java
>  24d7763 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  edea5b6 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java
>  5fe6625 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  4cd00e6 
> 
> 
> Diff: https://reviews.apache.org/r/65704/diff/3/
> 
> 
> Testing
> -------
> 
> unit tests succeeded
> 
> 
> Thanks,
> 
> Na Li
> 
>

Reply via email to