> On March 1, 2018, 5:39 p.m., Steve Moist wrote: > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > > Lines 140 (patched) > > <https://reviews.apache.org/r/65866/diff/1/?file=1968324#file1968324line144> > > > > I don't find stating illegargumentexception to be helpful. What kind > > of illegal argument woould trigger this exception to happen?
See KeyValue class line 37 - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65866/#review198456 ----------------------------------------------------------- On March 1, 2018, 11:47 a.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65866/ > ----------------------------------------------------------- > > (Updated March 1, 2018, 11:47 a.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar > kalvagadda, Liam Sargent, Na Li, Steve Moist, Sergio Pena, Vadim Spector, and > Xinran Tinney. > > > Repository: sentry > > > Description > ------- > > There are a bunch of improvements that should be made to > ResourceAuthorizationProvider. For example, exceptions thrown by > privilegeFactory.createPrivilege are not gracefully handled. Makes debugging > hard. > > We also need to add a lot more logging that needs to be added to related > classes > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java > 7565a34b5 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 09bd9b566 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java > 447deaf58 > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java > 4e944e5f2 > > sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java > ab5560994 > > sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/PrivilegeFactory.java > 2f8296bfa > > sentry-policy/sentry-policy-engine/src/main/java/org/apache/sentry/policy/engine/common/CommonPrivilegeFactory.java > d338f0edd > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > a9b98f319 > > > Diff: https://reviews.apache.org/r/65866/diff/1/ > > > Testing > ------- > > mvn -f sentry-binding/sentry-binding-hive/pom.xml test > mvn -f sentry-core/sentry-core-common/pom.xml test > mvn -f sentry-policy/sentry-policy-common/pom.xml test > mvn -f sentry-policy/sentry-policy-engine/pom.xml test > mvn -f sentry-provider/sentry-provider-common/pom.xml test > > > Thanks, > > Arjun Mishra > >
