-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65866/
-----------------------------------------------------------
(Updated Feb. 6, 2019, 7:35 p.m.)
Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, Steve
Moist, and Sergio Pena.
Bugs: SENTRY-2146
https://issues.apache.org/jira/browse/SENTRY-2146
Repository: sentry
Description
-------
There are a bunch of improvements that should be made to
ResourceAuthorizationProvider. For example, exceptions thrown by
privilegeFactory.createPrivilege are not gracefully handled. Makes debugging
hard.
We also need to add a lot more logging that needs to be added to related classes
Diffs
-----
sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java
7565a34b5
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
09bd9b566
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
447deaf58
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
4e944e5f2
sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java
ab5560994
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java
a9b98f319
Diff: https://reviews.apache.org/r/65866/diff/3/
Testing
-------
mvn -f sentry-binding/sentry-binding-hive/pom.xml test
mvn -f sentry-core/sentry-core-common/pom.xml test
mvn -f sentry-policy/sentry-policy-common/pom.xml test
mvn -f sentry-policy/sentry-policy-engine/pom.xml test
mvn -f sentry-provider/sentry-provider-common/pom.xml test
File Attachments (updated)
----------------
New diff. Not able to update
https://reviews.apache.org/media/uploaded/files/2019/02/06/5b613338-7181-4bbe-bac5-66129cdbc095__SENTRY-2146.04.patch
Thanks,
Arjun Mishra
