> On March 2, 2018, 3:43 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerFactory.java > > Line 34 (original), 34 (patched) > > <https://reviews.apache.org/r/65867/diff/1/?file=1968325#file1968325line34> > > > > can you use "the hive-site.xml at hive server 2" instead of > > "hive-site.xml"? hive-site.xml can be at both hive server 2, HMS, or at > > sentry. > > Colm O hEigeartaigh wrote: > It's hiveserver2-site.xml though not hive-site.xml?
In our unit tests and e2e tests, the hive configuration files are always called hive-site.xml. Would it be confusing for someone to see hiveserver2-site.xml? I searched the code, there is no other places refer such file name. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65867/#review198529 ----------------------------------------------------------- On March 1, 2018, 12:32 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65867/ > ----------------------------------------------------------- > > (Updated March 1, 2018, 12:32 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-2147 > https://issues.apache.org/jira/browse/SENTRY-2147 > > > Repository: sentry > > > Description > ------- > > The Javadoc for SentryHiveAuthorizerFactory incorrectly states that it should > be configured as follows: > > <property> > <name>hive.security.authorization.enable</name> > > <value>org.apache.sentry.binding.hive.authz.SentryHiveAuthorizerFactory</value> > </property> > > Instead it should be "hive.security.authorization.manager". > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerFactory.java > db8e4288 > > > Diff: https://reviews.apache.org/r/65867/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
