> On March 2, 2018, 7:34 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerFactory.java > > Line 34 (original), 34 (patched) > > <https://reviews.apache.org/r/65867/diff/1/?file=1968325#file1968325line34> > > > > Colm, > > > > Are you sre that this configuration is not needed for metastore?
Yeah I've removed the change to the wording on "hive-site.xml". Now the patch just has the correct tag to use. - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65867/#review198544 ----------------------------------------------------------- On March 1, 2018, 12:32 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65867/ > ----------------------------------------------------------- > > (Updated March 1, 2018, 12:32 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-2147 > https://issues.apache.org/jira/browse/SENTRY-2147 > > > Repository: sentry > > > Description > ------- > > The Javadoc for SentryHiveAuthorizerFactory incorrectly states that it should > be configured as follows: > > <property> > <name>hive.security.authorization.enable</name> > > <value>org.apache.sentry.binding.hive.authz.SentryHiveAuthorizerFactory</value> > </property> > > Instead it should be "hive.security.authorization.manager". > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerFactory.java > db8e4288 > > > Diff: https://reviews.apache.org/r/65867/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
