----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65768/#review199197 -----------------------------------------------------------
Lina, Don't we need changes to notifcation processor to handle this? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java Line 363 (original), 363 (patched) <https://reviews.apache.org/r/65768/#comment279491> if changing the database is not supported hive should throw an error, if hive allows that command sentry should be handling it. 1. update the path information 2. change the permission - kalyan kumar kalvagadda On March 7, 2018, 10:39 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65768/ > ----------------------------------------------------------- > > (Updated March 7, 2018, 10:39 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > fix the bug that moves privilege to wrong table when DB name changes in alter > table rename > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 7a31a01 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java > c30d982 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > b410027 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateModifier.java > c6be80d > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java > 5fe6625 > > > Diff: https://reviews.apache.org/r/65768/diff/3/ > > > Testing > ------- > > unit test succeeded > > > Thanks, > > Na Li > >
