-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65768/#review200840
-----------------------------------------------------------




sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java
Lines 364-379 (original), 364-373 (patched)
<https://reviews.apache.org/r/65768/#comment281745>

    I don't quite understand this logic.
    
    alter table could do couple of things
    1. alter the table name (alter table db1.tb1 rename to db1.tb2)
    2. move the table from one database to another one (alter table db1.tb2 
rename to db2.tb2;)
    3. both (alter table db1.tb2 rename to db2.tb3)
    
    From what I understand, difference in prevDbName and newDbName means that 
table is moved from one database to another.


- kalyan kumar kalvagadda


On April 10, 2018, 7:22 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65768/
> -----------------------------------------------------------
> 
> (Updated April 10, 2018, 7:22 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and 
> Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> fix the bug that moves privilege to wrong table when DB name changes in alter 
> table rename
> 
> 
> Diffs
> -----
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  83c0fc4 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java
>  c30d982 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
>  b410027 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateModifier.java
>  c6be80d 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java
>  5fe6625 
> 
> 
> Diff: https://reviews.apache.org/r/65768/diff/4/
> 
> 
> Testing
> -------
> 
> unit test succeeded
> 
> 
> Thanks,
> 
> Na Li
> 
>

Reply via email to