----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66339/#review200211 -----------------------------------------------------------
Ship it! Ship It! - Na Li On March 29, 2018, 1:08 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66339/ > ----------------------------------------------------------- > > (Updated March 29, 2018, 1:08 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-2168 > https://issues.apache.org/jira/browse/SENTRY-2168 > > > Repository: sentry > > > Description > ------- > > When HDFS-SYNC is disabled in sentry sentry server, sentry permissions are > not updated when the table is altered. This should be fixed. > > > > When a table is renamed, sentry permissions will not be renamed unless the > HDFS-SYNC is enabled. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java > e5ad3b5df5f1fdacd91b18f29394ec8275bb31e1 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java > ed80e88dfca8357e546f0cc790fb904c6fa5084a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java > 9634ea1acb0158db01d58570111b1ea89a6e8d58 > > > Diff: https://reviews.apache.org/r/66339/diff/1/ > > > Testing > ------- > > Made sure that all the tests passed and also added new test this scenario. > > > Thanks, > > kalyan kumar kalvagadda > >
