----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/#review202072 -----------------------------------------------------------
Ship it! Thanks, the change looks better. FYI, keeping the levels was a good choice. I did try the patch and it couldn't be applie dwith p0. > /tmp/smart-apply-patch.sh SENTRY-2212-002.patch error: a/dev-support/smart-apply-patch.sh: does not exist in index Going to apply patch with: git apply -p1 > So it ended be applied on p1. - Sergio Pena On April 27, 2018, 4:47 p.m., Steve Moist wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66787/ > ----------------------------------------------------------- > > (Updated April 27, 2018, 4:47 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Removed using the patch command and instead am using "git apply" for diffs. > > > Diffs > ----- > > dev-support/smart-apply-patch.sh fce27354 > > > Diff: https://reviews.apache.org/r/66787/diff/2/ > > > Testing > ------- > > Used it to apply a patch, then tested with apply a patch with conflicts, > doing a dry-run. Also tested with rename/moves. > > > Thanks, > > Steve Moist > >
