> On May 2, 2018, 2:09 p.m., Ben Iglauer wrote: > > Does SentryHiveConstants.PRIVILEGE_NOT_SUPPORTED end in a space? If not, > > SentryHiveConstants.PRIVILEGE_NOT_SUPPORTED + "to EMPTY URI path" will not > > be formatted correctly.
Yes it does. See here: public static final String PRIVILEGE_NOT_SUPPORTED = "Sentry does not support privilege: "; - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202277 ----------------------------------------------------------- On May 1, 2018, 10:17 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66898/ > ----------------------------------------------------------- > > (Updated May 1, 2018, 10:17 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > We can grant privileges to URI's with EMPTY or NULL locations. This should > not be allowed > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > 21a6abf82 > > > Diff: https://reviews.apache.org/r/66898/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
