----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202681 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java Lines 2259 (patched) <https://reviews.apache.org/r/66898/#comment284654> changing wording on this "Grant ALL on Empty URI is not allowed" sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java Lines 2264 (patched) <https://reviews.apache.org/r/66898/#comment284655> remove this section. It has nothing to do with the test case sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java Lines 2273 (patched) <https://reviews.apache.org/r/66898/#comment284656> change wording - Na Li On May 8, 2018, 7 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66898/ > ----------------------------------------------------------- > > (Updated May 8, 2018, 7 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > We can grant privileges to URI's with EMPTY or NULL locations. This should > not be allowed > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > 3ac49fa6a > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > 8485ca37f > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 8ac3c0d51 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > b41002783 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > ae1316423 > > > Diff: https://reviews.apache.org/r/66898/diff/5/ > > > Testing > ------- > > $ mvn -f sentry-binding/sentry-binding-hive/pom.xml test > $ mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test > $ mvn -f sentry-provider/sentry-provider-db/pom.xml test > > > Thanks, > > Arjun Mishra > >
