> On May 29, 2018, 9:40 p.m., Na Li wrote: > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > > Lines 341 (patched) > > <https://reviews.apache.org/r/67293/diff/4/?file=2031647#file2031647line341> > > > > how to make sure client and server uses the same event type? It is easy > > to have issue using string as eventType. for example, client puts > > "create_table", but server expects "createTable". > > kalyan kumar kalvagadda wrote: > Lina, > > Both client and server use > org.apache.hadoop.hive.metastore.messaging.EventMessage.EventType. Values for > these enums are strings.
Then you should make a comment about this type. It is enum. the client and server should use its string value. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/#review204015 ----------------------------------------------------------- On May 29, 2018, 8:32 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67293/ > ----------------------------------------------------------- > > (Updated May 29, 2018, 8:32 p.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Bugs: SENTRY--2243 > https://issues.apache.org/jira/browse/SENTRY--2243 > > > Repository: sentry > > > Description > ------- > > When ever below events happen sentry should be updated with owner information > so that owner privileges can be updated accordingly. > > Create/drop database > Create/drop table > Alter database/table > This needs new messages types, requests and responses to be added. > > > Diffs > ----- > > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java > fbbd725d31bccba516c266175bc8f993f4f3287f > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotification.java > PRE-CREATION > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotificationResponse.java > PRE-CREATION > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryObjectOwnerType.java > PRE-CREATION > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > dcbd7e488bab46cce1b1369bb92c4549384ef38a > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > c23683f78193d821f41c02b30ab723eafa932d4e > > > Diff: https://reviews.apache.org/r/67293/diff/4/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
