----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67293/#review204110 -----------------------------------------------------------
sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift Lines 345 (patched) <https://reviews.apache.org/r/67293/#comment286497> When owner name or owner type is changed, how can you tell from eventType? I suspect the event type is ALTER_TABLE, and you need to have old authorizable to tell if the table property is changed or it is table rename etc. Need to think through to make sure you have all necessary info public static enum EventType { CREATE_DATABASE("CREATE_DATABASE"), DROP_DATABASE("DROP_DATABASE"), CREATE_TABLE("CREATE_TABLE"), DROP_TABLE("DROP_TABLE"), ADD_PARTITION("ADD_PARTITION"), DROP_PARTITION("DROP_PARTITION"), ALTER_TABLE("ALTER_TABLE"), ALTER_PARTITION("ALTER_PARTITION"), INSERT("INSERT"), CREATE_FUNCTION("CREATE_FUNCTION"), DROP_FUNCTION("DROP_FUNCTION"), CREATE_INDEX("CREATE_INDEX"), DROP_INDEX("DROP_INDEX"), ALTER_INDEX("ALTER_INDEX"); - Na Li On May 31, 2018, 12:11 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67293/ > ----------------------------------------------------------- > > (Updated May 31, 2018, 12:11 p.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Bugs: SENTRY--2243 > https://issues.apache.org/jira/browse/SENTRY--2243 > > > Repository: sentry > > > Description > ------- > > When ever below events happen sentry should be updated with owner information > so that owner privileges can be updated accordingly. > > Create/drop database > Create/drop table > Alter database/table > This needs new messages types, requests and responses to be added. > > > Diffs > ----- > > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java > fbbd725d31bccba516c266175bc8f993f4f3287f > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotification.java > PRE-CREATION > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotificationResponse.java > PRE-CREATION > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryObjectOwnerType.java > PRE-CREATION > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > dcbd7e488bab46cce1b1369bb92c4549384ef38a > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > c23683f78193d821f41c02b30ab723eafa932d4e > > > Diff: https://reviews.apache.org/r/67293/diff/5/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
