----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67440/#review204278 -----------------------------------------------------------
sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/NotificationHandler.java Lines 74 (patched) <https://reviews.apache.org/r/67440/#comment286693> I'm concerned about the parameters types. How is it going to look like when user privileges is supported? We would need the TAlterSentryUserRequest, right? - Sergio Pena On June 4, 2018, 9:04 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67440/ > ----------------------------------------------------------- > > (Updated June 4, 2018, 9:04 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. > > > Bugs: sentry-2158 > https://issues.apache.org/jira/browse/sentry-2158 > > > Repository: sentry > > > Description > ------- > > add function for grant and revoke user privilege in NotificationHandler > > > Diffs > ----- > > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/NotificationHandler.java > 341b85a > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/NotificationHandlerInvoker.java > 39537c2 > > > Diff: https://reviews.apache.org/r/67440/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
