> On June 4, 2018, 9:33 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/NotificationHandler.java > > Lines 74 (patched) > > <https://reviews.apache.org/r/67440/diff/1/?file=2035073#file2035073line74> > > > > I'm concerned about the parameters types. How is it going to look like > > when user privileges is supported? We would need the > > TAlterSentryUserRequest, right?
Since the current owner privilege is from event notification, we don't have some info. Can we have another function with different types of request and response when formally support user privilege? - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67440/#review204278 ----------------------------------------------------------- On June 4, 2018, 9:04 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67440/ > ----------------------------------------------------------- > > (Updated June 4, 2018, 9:04 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. > > > Bugs: sentry-2158 > https://issues.apache.org/jira/browse/sentry-2158 > > > Repository: sentry > > > Description > ------- > > add function for grant and revoke user privilege in NotificationHandler > > > Diffs > ----- > > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/NotificationHandler.java > 341b85a > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/NotificationHandlerInvoker.java > 39537c2 > > > Diff: https://reviews.apache.org/r/67440/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
