----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/ -----------------------------------------------------------
(Updated June 27, 2018, 10:29 p.m.) Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena. Bugs: sentry-2280 https://issues.apache.org/jira/browse/sentry-2280 Repository: sentry Description ------- The required fields in TSentryHmsEventNotification and TSentryHmsEventNotificationResponse are not filled, which caused the request from client to sever to be null. And the response from server to client is null. Change the data structure to make owner info optional, and fill other required fields properly Diffs (updated) ----- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHmsEvent.java 42be3c3 sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java f7d1b07 sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/metastore/TestSentrySyncHMSNotificationsPostEventListener.java 8e79cac sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotification.java 75b2799 sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 1b0de6a sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java fe6389c Diff: https://reviews.apache.org/r/67749/diff/6/ Changes: https://reviews.apache.org/r/67749/diff/5-6/ Testing ------- Manually trace into code and verfied that now the server receives request and client receiveds response correctly Thanks, Na Li