-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67879/#review205975
-----------------------------------------------------------




sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
Lines 99-100 (original), 99-102 (patched)
<https://reviews.apache.org/r/67879/#comment288926>

    Can we reuse the string instead?
    
    Like, 
      String msg = String.format(...);
      LOGGER.info(msg);
      System.out.println(msg);
      
    Same for all the other messages.



sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java
Lines 417 (patched)
<https://reviews.apache.org/r/67879/#comment288925>

    We have the date in the log, why is it needed to print it in the console?



sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
Lines 244 (patched)
<https://reviews.apache.org/r/67879/#comment288928>

    Why do we need to print the timestamp in the console? Can users go to the 
log?
    
    Perhaps is good to print one single message and how much it took?


- Sergio Pena


On July 11, 2018, 4:42 p.m., Arjun Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67879/
> -----------------------------------------------------------
> 
> (Updated July 11, 2018, 4:42 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2309
>     https://issues.apache.org/jira/browse/SENTRY-2309
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Adding to std.out will allow full snapshot timeline messages like has fetch 
> started, or has fetch been persisted, to be separated out from the rest of 
> the logs and be identified more easily
> 
> 
> Diffs
> -----
> 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
>  065adb74f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java
>  7667c47d5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
>  9d1a92f18 
> 
> 
> Diff: https://reviews.apache.org/r/67879/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Reply via email to