> On July 11, 2018, 5:32 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java
> > Lines 399 (patched)
> > <https://reviews.apache.org/r/67879/diff/2/?file=2058516#file2058516line399>
> >
> >     It is better " notification Id = %d: at time %d" than " notification Id 
> > = %d: %d"

The new diff is time stamp first then message. So then we explictly don't have 
to specify that it is time


- Arjun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67879/#review205974
-----------------------------------------------------------


On July 11, 2018, 4:42 p.m., Arjun Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67879/
> -----------------------------------------------------------
> 
> (Updated July 11, 2018, 4:42 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2309
>     https://issues.apache.org/jira/browse/SENTRY-2309
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Adding to std.out will allow full snapshot timeline messages like has fetch 
> started, or has fetch been persisted, to be separated out from the rest of 
> the logs and be identified more easily
> 
> 
> Diffs
> -----
> 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
>  065adb74f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java
>  7667c47d5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
>  9d1a92f18 
> 
> 
> Diff: https://reviews.apache.org/r/67879/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Reply via email to