----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68787/#review208857 -----------------------------------------------------------
Arjun, Can you use an example to explain the optimization this chnage is going to make? - kalyan kumar kalvagadda On Sept. 20, 2018, 7:32 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68787/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2018, 7:32 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2406 > https://issues.apache.org/jira/browse/SENTRY-2406 > > > Repository: sentry > > > Description > ------- > > When building input or output hierarchy list, we iterate over all ReadEntity > inputs received from Hive. The inputs particularly have accessed columns that > can repeat for other ReadEntity objects. This happens definitively when a > table has partitions. We should in general protect Sentry from not having to > authorize over a list of DBModelAuthorizable objects when it has already been > done. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java > da1956b8e > > > Diff: https://reviews.apache.org/r/68787/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
