-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68787/
-----------------------------------------------------------
(Updated Sept. 21, 2018, 5:05 p.m.)
Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
Changes
-------
Implementing a set of list to remove duplicates
Bugs: SENTRY-2406
https://issues.apache.org/jira/browse/SENTRY-2406
Repository: sentry
Description
-------
When building input or output hierarchy list, we iterate over all ReadEntity
inputs received from Hive. The inputs particularly have accessed columns that
can repeat for other ReadEntity objects. This happens definitively when a table
has partitions. We should in general protect Sentry from not having to
authorize over a list of DBModelAuthorizable objects when it has already been
done.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java
6a1556fa7
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
f0764767f
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
da1956b8e
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java
5beda9f80
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java
0909656be
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/util/SentryAuthorizerUtil.java
dd6936c19
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java
3bbf6fb19
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/AccessURI.java
dd8104d72
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Column.java
305fd1f5a
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Database.java
0d94805c7
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Server.java
33e735ef2
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Table.java
b161d0291
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/View.java
f6d84997e
Diff: https://reviews.apache.org/r/68787/diff/2/
Changes: https://reviews.apache.org/r/68787/diff/1-2/
Testing
-------
Thanks,
Arjun Mishra
